[all-commits] [llvm/llvm-project] 828089: [lldb] Remove RTTI in ClangExternalASTSourceCommon...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8280896bd1b055a192d9e7d482b0ffa14ee88e3a
      https://github.com/llvm/llvm-project/commit/8280896bd1b055a192d9e7d482b0ffa14ee88e3a
  Author: Raphael Isemann <risemann at apple.com>
  Date:   2019-12-15 (Sun, 15 Dec 2019)

  Changed paths:
    M lldb/include/lldb/Symbol/ClangExternalASTSourceCommon.h
    M lldb/source/Symbol/ClangASTContext.cpp
    M lldb/source/Symbol/ClangExternalASTSourceCommon.cpp

  Log Message:
  -----------
  [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

Summary:
Currently we do our RTTI check for ClangExternalASTSourceCommon by using this global map of
ClangExternalASTSourceCommon where every instance is registering and deregistering itself
on creation/destruction. Then we can do the RTTI check by looking up in this map from ClangASTContext.

This patch removes this whole thing and just adds LLVM-style RTTI support to ClangExternalASTSourceCommon
which is possible with D71397.

Reviewers: labath, aprantl

Reviewed By: labath

Subscribers: JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D71398