[all-commits] [llvm/llvm-project] c2f183: Move ASTRecordReader into its own header; NFC.

[John McCall via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c2f18315ff53006e44afe065368019e41cb98053
      https://github.com/llvm/llvm-project/commit/c2f18315ff53006e44afe065368019e41cb98053
  Author: John McCall <rjmccall at apple.com>
  Date:   2019-12-14 (Sat, 14 Dec 2019)

  Changed paths:
    M clang/include/clang/Serialization/ASTReader.h
    A clang/include/clang/Serialization/ASTRecordReader.h
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTReaderDecl.cpp
    M clang/lib/Serialization/ASTReaderStmt.cpp
    M clang/lib/StaticAnalyzer/Frontend/ModelInjector.cpp

  Log Message:
  -----------
  Move ASTRecordReader into its own header; NFC.

AbstractBasicReader.h has quite a few dependencies already,
and that's only likely to increase.  Meanwhile, ASTRecordReader
is really an implementation detail of the ASTReader that is only
used in a small number of places.

I've kept it in a public header for the use of projects like Swift
that might want to plug in to Clang's serialization framework.

I've also moved OMPClauseReader into an implementation file,
although it can't be made private because of friendship.


  Commit: 2ac702aaf09174432905a9f05b31418a89019437
      https://github.com/llvm/llvm-project/commit/2ac702aaf09174432905a9f05b31418a89019437
  Author: John McCall <rjmccall at apple.com>
  Date:   2019-12-14 (Sat, 14 Dec 2019)

  Changed paths:
    A clang/include/clang/Serialization/ASTRecordWriter.h
    M clang/include/clang/Serialization/ASTWriter.h
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/lib/Serialization/ASTWriterDecl.cpp
    M clang/lib/Serialization/ASTWriterStmt.cpp

  Log Message:
  -----------
  Move ASTRecordWriter into its own header; NFC.

Similar motivations to the movement of ASTRecordReader:
AbstractBasicWriter.h already has quite a few dependencies,
and it's going to get pretty large as we generate more and more
into it.  Meanwhile, most clients don't depend on this detail of
the implementation and shouldn't need to be recompiled.

I've also made OMPClauseWriter private, like it belongs.


Compare: https://github.com/llvm/llvm-project/compare/816985c12053...2ac702aaf091