[all-commits] [llvm/llvm-project] 8bd9d0: [libcxx] [test] Query the target platform, not the...

Louis Dionne via All-commits all-commits at lists.llvm.org
Tue Dec 10 13:36:19 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8bd9d0bff21b6732c122365de793de12fef9c681
      https://github.com/llvm/llvm-project/commit/8bd9d0bff21b6732c122365de793de12fef9c681
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2019-12-10 (Tue, 10 Dec 2019)

  Changed paths:
    M libcxx/utils/libcxx/test/config.py
    M libcxx/utils/libcxx/test/executor.py
    M libcxx/utils/libcxx/test/format.py
    M libcxx/utils/libcxx/test/target_info.py

  Log Message:
  -----------
  [libcxx] [test] Query the target platform, not the host one

target_info is inferred to WindowsLocalTI on Windows hosts unless
specified otherwise. In the latter case, it doesn't make sense to use
Windows-specific settings if the target is not Windows.

This change should not break anything, because target_info is inferred
based on what platform.system() returns. self.is_windows was set based
on the same platform.system() call.

Thanks to Sergej Jaskiewicz for the patch.

Differential Revision: https://reviews.llvm.org/D68275




More information about the All-commits mailing list