[all-commits] [llvm/llvm-project] 14f3d1: [lldb] Actually enable wchar support in Editline w...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 14f3d13412cb2eac87f1c0ae74ed2af7ace1580f
      https://github.com/llvm/llvm-project/commit/14f3d13412cb2eac87f1c0ae74ed2af7ace1580f
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2019-12-10 (Tue, 10 Dec 2019)

  Changed paths:
    M lldb/include/lldb/Host/Editline.h
    A lldb/packages/Python/lldbsuite/test/iohandler/unicode/TestUnicode.py

  Log Message:
  -----------
  [lldb] Actually enable wchar support in Editline when it is defined in the host config

Summary:
Our Editline implementation in LLDB supports using the wchar interface of Editline which
should improve handling of unicode input when using Editline. At the moment we essentially
just ignore unicode input and echo the escaped unicode code point (`\U1234`) to the command line
(which we then also incorrectly treat as multiple characters, so console navigation is also broken afterwards).

This patch just adds the include to the host config file which already contains the LLDB_EDITLINE_USE_WCHAR
define to enable the Editline support (we just never included it in the file before). With this we now actually
echo back unicode characters on macOS and we no longer ignore unicode input. On Linux this doesn't
seem to improve the echoing back of characters but at least it fixes that we ignore unicode input.

Reviewers: labath

Reviewed By: labath

Subscribers: JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D71251