[all-commits] [llvm/llvm-project] dac5dd: [llvm-readelf/llvm-readobj] - Improved the error r...

[Georgii Rymar via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dac5ddb482361cde11ac43e94c43acc94a3b78aa
      https://github.com/llvm/llvm-project/commit/dac5ddb482361cde11ac43e94c43acc94a3b78aa
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2019-12-10 (Tue, 10 Dec 2019)

  Changed paths:
    M llvm/test/Object/invalid.test
    M llvm/test/tools/llvm-readobj/ELF/verdef-invalid.test
    M llvm/test/tools/llvm-readobj/ELF/verneed-invalid.test
    M llvm/test/tools/llvm-readobj/ELF/versym-invalid.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readelf/llvm-readobj] - Improved the error reporting in a few method related to versioning.

I was investigating a change previously discussed that eliminates an excessive
empty lines from the output when we report warnings and errors
(https://reviews.llvm.org/D70826#inline-639055) and found
that we need this refactoring or alike to achieve that.

The problem is that some of our functions that finds symbol versions just
fail instead of returning errors or printing warnings. Another problem
is that they might print a warning on the same line with the regular output.
In this patch I've splitted getting of the version information and dumping of it
for GNU printVersionSymbolSection(). I had to change a few methods to return
Error or Expected<> to do that properly.

Differential revision: https://reviews.llvm.org/D71118