[all-commits] [llvm/llvm-project] 479e3b: [NFCi][llvm][MIRVRegNamerUtils] Making some code c...

Puyan Lotfi via All-commits all-commits at lists.llvm.org
Mon Dec 9 20:38:00 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 479e3b85e27b8bb0c6978138da54adaa91e703d8
      https://github.com/llvm/llvm-project/commit/479e3b85e27b8bb0c6978138da54adaa91e703d8
  Author: Puyan Lotfi <puyan at puyan.org>
  Date:   2019-12-09 (Mon, 09 Dec 2019)

  Changed paths:
    M llvm/lib/CodeGen/MIRVRegNamerUtils.cpp
    M llvm/lib/CodeGen/MIRVRegNamerUtils.h

  Log Message:
  -----------
  [NFCi][llvm][MIRVRegNamerUtils] Making some code cleanup and stylistic changes.

Making some changes to MIRVRegNamerUtils.cpp to use some more modern c++
features as well as some changes to generally make the code more concise
and more understandable.

I make this an NFCi because in one case I drop the whole
"if (!MO->isDef()) MO->setIsKill(false);" thing that was added in the
original implementation, generally because I don't think this is really
semantically sound. I also changed up the implementation of
VRegRenamer::createVirtualRegisterWithLowerName somewhat because I am
now lower-casing the name unconditionally because I confirmed that that
was in fact aditya_nandakumar at apple.com's intent.

In all other cases, behavior should not be changed.

Differential Revision: https://reviews.llvm.org/D71182




More information about the All-commits mailing list