[all-commits] [llvm/llvm-project] 1164d4: Include Stmt.h where it seems to be necessary for ...

Reid Kleckner via All-commits all-commits at lists.llvm.org
Mon Dec 9 13:09:16 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1164d43855fd5b58fde221445ab0e407c0bd92ee
      https://github.com/llvm/llvm-project/commit/1164d43855fd5b58fde221445ab0e407c0bd92ee
  Author: Reid Kleckner <rnk at google.com>
  Date:   2019-12-09 (Mon, 09 Dec 2019)

  Changed paths:
    M clang/include/clang/Tooling/Refactoring/ASTSelection.h

  Log Message:
  -----------
  Include Stmt.h where it seems to be necessary for modules builds

Summary:
After 60573ae6fe50 removed an include of Expr.h from ASTContext.h, this
header fails to compile in some modular build configurations. I have not
been able to reproduce the problem locally. The header compiles fine in
isolation. However, based on reading the code, it seems like it would
require Stmt to be complete. Based on that intuition, we decided to add the
include.

Reviewers: rdhindsa

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D71222




More information about the All-commits mailing list