[all-commits] [llvm/llvm-project] a38396: Revert 393dacacf7e7 "[ARM] Enable TypePromotion by...

Hans via All-commits all-commits at lists.llvm.org
Mon Dec 9 00:45:38 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a38396939c548f9ad8e94c9baa7198fdb26dedc2
      https://github.com/llvm/llvm-project/commit/a38396939c548f9ad8e94c9baa7198fdb26dedc2
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2019-12-09 (Mon, 09 Dec 2019)

  Changed paths:
    M llvm/lib/CodeGen/TypePromotion.cpp
    M llvm/test/Transforms/TypePromotion/ARM/calls.ll
    M llvm/test/Transforms/TypePromotion/ARM/casts.ll
    M llvm/test/Transforms/TypePromotion/ARM/clear-structures.ll
    M llvm/test/Transforms/TypePromotion/ARM/icmps.ll
    M llvm/test/Transforms/TypePromotion/ARM/phis-ret.ll
    M llvm/test/Transforms/TypePromotion/ARM/pointers.ll
    M llvm/test/Transforms/TypePromotion/ARM/signed-icmps.ll
    M llvm/test/Transforms/TypePromotion/ARM/signed.ll
    M llvm/test/Transforms/TypePromotion/ARM/switch.ll
    M llvm/test/Transforms/TypePromotion/ARM/wrapping.ll

  Log Message:
  -----------
  Revert 393dacacf7e7 "[ARM] Enable TypePromotion by default"

This caused "Too many bits for uint64_t" asserts when building Chromium. See
https://crbug.com/1031978#c2 for a reproducer. I'll follow up on the
llvm-commits thread with a creduced version.

> ARMCodeGenPrepare has already been generalized and renamed to
> TypePromotion. We've had it enabled and tested downstream for a
> while, so enable it by default.
>
> Differential Revision: https://reviews.llvm.org/D70998




More information about the All-commits mailing list