[all-commits] [llvm/llvm-project] 68f464: [llvm-dwarfdump][Statistics] Unify coverage statis...

[chbessonova via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 68f464ac2ef5de8cb2e8beaeee43c435c536539e
      https://github.com/llvm/llvm-project/commit/68f464ac2ef5de8cb2e8beaeee43c435c536539e
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2019-12-08 (Sun, 08 Dec 2019)

  Changed paths:
    M llvm/test/tools/llvm-dwarfdump/X86/locstats.ll
    M llvm/test/tools/llvm-dwarfdump/X86/statistics-base-address.s
    M llvm/test/tools/llvm-dwarfdump/X86/statistics-dwo.test
    M llvm/test/tools/llvm-dwarfdump/X86/statistics-v3.test
    M llvm/test/tools/llvm-dwarfdump/X86/statistics.ll
    M llvm/tools/llvm-dwarfdump/Statistics.cpp
    M llvm/utils/llvm-locstats/llvm-locstats.py

  Log Message:
  -----------
  [llvm-dwarfdump][Statistics] Unify coverage statistic computation

Summary:
The patch removes OffsetToFirstDefinition in the 'scope bytes total'
statistic computation. Thus it unifies the way the scope and the coverage
buckets are computed. The rationals behind that are the following:

1. OffsetToFirstDefinition was used to calculate the variable's life range.
However, there is no simple way to do it accurately, so the scope calculated
this way might be misleading. See D69027 for more details on the subject.
2. Both 'scope bytes total' and coverage buckets seem to be intended
to represent the same data in different ways. Otherwise, the statistics
might be controversial and confusing.

Note that the approach gives up a thorough evaluation of debug information
completeness (i.e. coverage buckets by themselves doesn't tell how good
the debug information is). Only changes in coverage over time make
a 'physical' sense.

Reviewers: djtodoro, aprantl, vsk, dblaikie, avl

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70548