[all-commits] [llvm/llvm-project] 198fbc: Driver: Don't look for libc++ headers in the insta...

pcc via All-commits all-commits at lists.llvm.org
Fri Dec 6 18:25:03 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 198fbcb817492ff45946e3f7517de15e8cdf0607
      https://github.com/llvm/llvm-project/commit/198fbcb817492ff45946e3f7517de15e8cdf0607
  Author: Peter Collingbourne <peter at pcc.me.uk>
  Date:   2019-12-06 (Fri, 06 Dec 2019)

  Changed paths:
    M clang/lib/Driver/ToolChains/Linux.cpp
    A clang/test/Driver/android-no-installed-libcxx.cpp
    M clang/test/Driver/stdlibxx-isystem.cpp

  Log Message:
  -----------
  Driver: Don't look for libc++ headers in the install directory on Android.

The NDK uses a separate set of libc++ headers in the sysroot. Any headers
in the installation directory are not going to work on Android, not least
because they use a different name for the inline namespace (std::__1 instead
of std::__ndk1).

This effectively makes it impossible to produce a single toolchain that is
capable of targeting both Android and another platform that expects libc++
headers to be installed in the installation directory, such as Mac.

In order to allow this scenario to work, stop looking for headers in the
install directory on Android.

Differential Revision: https://reviews.llvm.org/D71154




More information about the All-commits mailing list