[all-commits] [llvm/llvm-project] 164e0f: [ASTImporter] Implicitly declare parameters for im...
Raphael Isemann via All-commits
all-commits at lists.llvm.org
Fri Dec 6 09:51:09 PST 2019
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 164e0fc5c7f782b174db5c87b37725ea0e174853
https://github.com/llvm/llvm-project/commit/164e0fc5c7f782b174db5c87b37725ea0e174853
Author: Raphael Isemann <risemann at apple.com>
Date: 2019-12-06 (Fri, 06 Dec 2019)
Changed paths:
M clang/lib/AST/ASTImporter.cpp
M clang/unittests/AST/ASTImporterTest.cpp
M clang/unittests/AST/Language.cpp
Log Message:
-----------
[ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls
Summary:
When Sema encounters a ObjCMethodDecl definition it declares the implicit parameters for the ObjCMethodDecl.
When importing such a method with the ASTImporter we need to do the same for the imported method
otherwise we will crash when generating code (where CodeGen expects that this was called by Sema).
Note I had to implement Objective-C[++] support in Language.cpp as this is the first test for Objective-C and this
would otherwise just hit this 'not implemented' assert when running the unit test.
Reviewers: martong, a.sidorin, shafik
Reviewed By: martong
Subscribers: rnkovacs, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71112
More information about the All-commits
mailing list