[all-commits] [llvm/llvm-project] 24439a: [clangd] Store index::SymbolKind in HoverInfo

[kadir çetinkaya via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 24439a761c5e21fda8f9410a5e80ff07b4ba03a2
      https://github.com/llvm/llvm-project/commit/24439a761c5e21fda8f9410a5e80ff07b4ba03a2
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2019-12-06 (Fri, 06 Dec 2019)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/Hover.h
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Store index::SymbolKind in HoverInfo

Summary:
LSP's SymbolKind has some shortcomings when it comes to C++ types,
index::SymbolKind has more detailed info like Destructor, Parameter, MACRO etc.

We are planning to make use of that information in our new Hover response, and
it would be nice to display the Symbol type in full detail, rather than some
approximation.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70723


  Commit: c5adbac9b85a53112a9fc9b72e64d2615e3e4df9
      https://github.com/llvm/llvm-project/commit/c5adbac9b85a53112a9fc9b72e64d2615e3e4df9
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2019-12-06 (Fri, 06 Dec 2019)

  Changed paths:
    M clang-tools-extra/clangd/Hover.h
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Switch Hover.All to structured tests

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70911


Compare: https://github.com/llvm/llvm-project/compare/18cf93a6eddf...c5adbac9b85a