[all-commits] [llvm/llvm-project] 0d2472: [lldb/IRExecutionUnit] Stop searching based on dem...

Pavel Labath via All-commits all-commits at lists.llvm.org
Fri Dec 6 01:17:32 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d2472ff6f604af842059d9a0098db274515a2d3
      https://github.com/llvm/llvm-project/commit/0d2472ff6f604af842059d9a0098db274515a2d3
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-12-06 (Fri, 06 Dec 2019)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
    M lldb/source/Expression/IRExecutionUnit.cpp

  Log Message:
  -----------
  [lldb/IRExecutionUnit] Stop searching based on demangled names

Summary:
This was causing problems on linux, where we'd end up calling the
deleting destructor instead of a regular one (because they have the same
demangled name), making a lot of mischief in the process.

The only place where this was necessary (according to the test suite, at
least) was to call a base structor instead of a complete one, but this
is now handled in a more targeted fashion.

TestCallOverriddenMethod is now re-enabled as it now passes reliably.

Reviewers: teemperor, JDevlieghere

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70722




More information about the All-commits mailing list