[all-commits] [llvm/llvm-project] 54682d: [DebugInfo] Handle call site values for instructio...

David via All-commits all-commits at lists.llvm.org
Thu Dec 5 02:51:28 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 54682d871d9e2d8f19ca58ce47a9673401d011ff
      https://github.com/llvm/llvm-project/commit/54682d871d9e2d8f19ca58ce47a9673401d011ff
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2019-12-05 (Thu, 05 Dec 2019)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    A llvm/test/DebugInfo/MIR/Hexagon/dbgcall-site-instr-before-bundled-call.mir

  Log Message:
  -----------
  [DebugInfo] Handle call site values for instructions before call bundle

Summary:
If a call is bundled then the code that looks for instructions that
produce parameter values would break when reaching the call's bundle
header, due to the `ifCall(/*AnyInBundle*/)` invocation returning true.

It is not enough to simply ignore bundle headers in the `isCall()`
invocation, as the bundle header may have defines of parameter registers
due to the call, meaning that such registers would incorrectly be
removed from the worklist. Therefore, do not look at bundle headers at
all.

Reviewers: djtodoro, NikolaPrica, aprantl, vsk

Reviewed By: aprantl, vsk

Subscribers: hiraditya, llvm-commits

Tags: #debug-info, #llvm

Differential Revision: https://reviews.llvm.org/D71024




More information about the All-commits mailing list