[all-commits] [llvm/llvm-project] dfe9a7: [lldb/Reproducers] Override capture with LLDB_CAPT...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Wed Dec 4 16:49:19 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dfe9a7943bf7a926e51b319a2c2f73e4b4b4cf43
      https://github.com/llvm/llvm-project/commit/dfe9a7943bf7a926e51b319a2c2f73e4b4b4cf43
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M lldb/source/Utility/Reproducer.cpp
    A lldb/test/Shell/Reproducer/TestCaptureEnvOverride.test
    M lldb/test/Shell/Reproducer/lit.local.cfg

  Log Message:
  -----------
  [lldb/Reproducers] Override capture with LLDB_CAPTURE_REPRODUCER env var

Make it possible to override reproducer capture with the
LLDB_CAPTURE_REPRODUCER environment variable.

The goal of this change is twofold.

(1) I want to be able to enable capturing reproducers during regular
    test runs, both locally and on the bots. To do so I need a way to
    force capture. I cannot do this through the Python API, because
    reproducer capture must be enabled *before* the debugger
    initialized, which happens automatically when doing `import lldb`.

(2) I want to provide an escape hatch for when reproducers are enabled
    by default. Downstream we have reproducer capture enabled by default
    in the driver.

This patch solves both problems by overriding the reproducer mode based
on the environment variable. Acceptable values are 0/1 and ON/OFF.


  Commit: acda2bc0adf62d9e54bf6d284f91e6cfa5b3cc6e
      https://github.com/llvm/llvm-project/commit/acda2bc0adf62d9e54bf6d284f91e6cfa5b3cc6e
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M lldb/test/API/lit.cfg.py
    M lldb/test/Shell/Reproducer/lit.local.cfg
    M lldb/test/Shell/lit.cfg.py

  Log Message:
  -----------
  [lldb/Reproducers] Propagate LLDB_CAPTURE_REPRODUCER to the test suite


Compare: https://github.com/llvm/llvm-project/compare/f65267ee16fb...acda2bc0adf6


More information about the All-commits mailing list