[all-commits] [llvm/llvm-project] 7e18ae: [LVI] Restructure caching

Nikita Popov via All-commits all-commits at lists.llvm.org
Wed Dec 4 08:50:07 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7e18aeba5062cd4324a9efb7bc25c9dbc4a34c2c
      https://github.com/llvm/llvm-project/commit/7e18aeba5062cd4324a9efb7bc25c9dbc4a34c2c
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2019-12-04 (Wed, 04 Dec 2019)

  Changed paths:
    M llvm/lib/Analysis/LazyValueInfo.cpp

  Log Message:
  -----------
  [LVI] Restructure caching

Variant on D70103. The caching is switched to always use a BB to
cache entry map, which then contains per-value caches. A separate
set contains value handles with a deletion callback. This allows us
to properly invalidate overdefined values.

A possible alternative would be to always cache by value first and
have per-BB maps/sets in the each cache entry. In that case we could
use a ValueMap and would avoid the separate value handle set. I went
with the BB indexing at the top level to make it easier to integrate
D69914, but possibly that's not the right choice.

Differential Revision: https://reviews.llvm.org/D70376




More information about the All-commits mailing list