[all-commits] [llvm/llvm-project] 4fd8f1: [MachineVerifier] Improve checks of target instru...

Jonas Paulsson via All-commits all-commits at lists.llvm.org
Tue Dec 3 01:31:30 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4fd8f11901b5bfb13a5fef597626dde31835873b
      https://github.com/llvm/llvm-project/commit/4fd8f11901b5bfb13a5fef597626dde31835873b
  Author: Jonas Paulsson <paulsson at linux.vnet.ibm.com>
  Date:   2019-12-03 (Tue, 03 Dec 2019)

  Changed paths:
    M llvm/lib/CodeGen/MachineVerifier.cpp
    M llvm/test/CodeGen/SPARC/fp128.ll
    A llvm/test/MachineVerifier/verify-regops.mir

  Log Message:
  -----------
  [MachineVerifier]  Improve checks of target instructions operands.

While working with a patch for instruction selection, the splitting of a
large immediate ended up begin treated incorrectly by the backend. Where a
register operand should have been created, it instead became an immediate. To
my surprise the machine verifier failed to report this, which at the time
would have been helpful.

This patch improves the verifier so that it will report this type of error.

This patch XFAILs CodeGen/SPARC/fp128.ll, which has been reported at
https://bugs.llvm.org/show_bug.cgi?id=44091

Review: thegameg, arsenm, fhahn
https://reviews.llvm.org/D63973




More information about the All-commits mailing list