[all-commits] [llvm/llvm-project] 35bc52: [libunwind] Emit dependent libraries only when det...

Michał Górny via All-commits all-commits at lists.llvm.org
Sun Dec 1 08:20:07 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 35bc5276ca31e3f0e8e87322153f410fa6224e59
      https://github.com/llvm/llvm-project/commit/35bc5276ca31e3f0e8e87322153f410fa6224e59
  Author: Michał Górny <mgorny at gentoo.org>
  Date:   2019-12-01 (Sun, 01 Dec 2019)

  Changed paths:
    M libunwind/CMakeLists.txt
    M libunwind/src/AddressSpace.hpp
    M libunwind/src/RWMutex.hpp

  Log Message:
  -----------
  [libunwind] Emit dependent libraries only when detected by CMake

996e62eef75 added Linux-specific dependent libraries to libunwind
sources.  As a result, building libunwind with modern LLD on *BSD
started failing due to trying to link libdl.  Instead, add those
libraries only if they were detected by CMake.

While technically we could create a long list of systems that need -ldl
and -lpthread, maintaining a duplicate list makes little sense when
CMake needs to detect it for non-LLD systems anyway.  Remove existing
system exceptions since they should be covered by the CMake check
anyway.

Remove -D_LIBUNWIND_HAS_COMMENT_LIB_PRAGMA since it is no longer
explicitly needed, if we make the library-specific defines dependent
on presence of this pragma support.

Differential Revision: https://reviews.llvm.org/D70868




More information about the All-commits mailing list