[all-commits] [llvm/llvm-project] b09425: Updated the OCaml/bitwriter.ml test for OCaml 4.06+

Dmitri Gribenko via All-commits all-commits at lists.llvm.org
Sat Nov 30 04:35:36 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b094258661e0064133679b8b51e981eefda07ec7
      https://github.com/llvm/llvm-project/commit/b094258661e0064133679b8b51e981eefda07ec7
  Author: Dmitri Gribenko <gribozavr at gmail.com>
  Date:   2019-11-30 (Sat, 30 Nov 2019)

  Changed paths:
    M llvm/test/Bindings/OCaml/bitwriter.ml

  Log Message:
  -----------
  Updated the OCaml/bitwriter.ml test for OCaml 4.06+

Since OCaml 4.02 (released in 2014), strings and bytes are different
types, but up until OCaml 4.06, the compiler defaulted to a
compatibility mode "unsafe-string". OCaml 4.06 flips the default to
"safe-string", breaking the test.

This change should be compatible with OCaml 4.02+, but is only truly
necessary for OCaml 4.06+.

For more information, see:

https://caml.inria.fr/pub/docs/manual-ocaml/libref/String.html
https://ocaml.org/releases/4.02.html




More information about the All-commits mailing list