[all-commits] [llvm/llvm-project] c67163: [lldb] NFC: refactor CompileUnit::ResolveSymbolCon...

[Konrad Kleine via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c671639af6a96c31d3c0e5487051bef28bad1640
      https://github.com/llvm/llvm-project/commit/c671639af6a96c31d3c0e5487051bef28bad1640
  Author: Konrad Kleine <kkleine at redhat.com>
  Date:   2019-11-28 (Thu, 28 Nov 2019)

  Changed paths:
    M lldb/include/lldb/Symbol/CompileUnit.h
    M lldb/source/API/SBThread.cpp
    M lldb/source/Core/AddressResolverFileLine.cpp
    M lldb/source/Symbol/CompileUnit.cpp

  Log Message:
  -----------
  [lldb] NFC: refactor CompileUnit::ResolveSymbolContext

Summary:
I found the above named method hard to read because it had

a) many nested blocks,
b) one return statement at the end with some logic involved,
c) a duplicated while-loop with just small differences in it.

I decided to refactor this function by employing an early exit strategy.
In order to capture the logic in the return statement and to not have it
repeated more than once I chose to implement a very small lamda function
that captures all the variables it needs.
I also replaced the two while-loops with just one.

This is a non-functional change (NFC).

Reviewers: jdoerfert, teemperor

Reviewed By: teemperor

Subscribers: labath, teemperor, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70774