[all-commits] [llvm/llvm-project] acd7fe: [AArch64][v8.3a] Don't emit LDRA '[xN]!' alias in ...

[Simon Tatham via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: acd7fe8636ab1d892a935ca747ed9bb6420e2253
      https://github.com/llvm/llvm-project/commit/acd7fe8636ab1d892a935ca747ed9bb6420e2253
  Author: Simon Tatham <simon.tatham at arm.com>
  Date:   2019-11-28 (Thu, 28 Nov 2019)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/test/MC/AArch64/armv8.3a-signed-pointer.s
    M llvm/test/MC/Disassembler/AArch64/armv8.3a-signed-pointer.txt

  Log Message:
  -----------
  [AArch64][v8.3a] Don't emit LDRA '[xN]!' alias in disassembly.

Summary:
In rG643ac6c0420b, the syntax `ldraa x1, [x0]!` was added as an alias
for `ldraa x1, [x0, #0]!`. That syntax is less obvious in meaning, and
also will not be accepted by assemblers that haven't been updated yet.
So it would be better not to emit it as the preferred disassembly for
that instruction.

This change lowers the EmitPriority of the new alias so that the more
explicit syntax `[x0, #0]!` is preferred by the disassembler. The new
syntax is still accepted by the assembler.

Reviewers: ab, ostannard

Reviewed By: ostannard

Subscribers: kristof.beyls, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70813