[all-commits] [llvm/llvm-project] d1a561: [lldb] Simplify and improve FileSpecTest

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d1a561d446809cc3b5c11c163b9aa5ba4957af68
      https://github.com/llvm/llvm-project/commit/d1a561d446809cc3b5c11c163b9aa5ba4957af68
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-11-28 (Thu, 28 Nov 2019)

  Changed paths:
    M lldb/unittests/Utility/FileSpecTest.cpp

  Log Message:
  -----------
  [lldb] Simplify and improve FileSpecTest

Summary:
A most of these tests create FileSpecs with a hardcoded style. Add
utility functions which create a file spec of a given style to simplify
things.

While in there add SCOPED_TRACE messages to tests which loop over
multiple inputs to ensure it's clear which of the inputs failed.

Reviewers: teemperor

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70814


  Commit: bf716eb807409adf6490cb1cf595fb51efbd3fe6
      https://github.com/llvm/llvm-project/commit/bf716eb807409adf6490cb1cf595fb51efbd3fe6
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-11-28 (Thu, 28 Nov 2019)

  Changed paths:
    M lldb/unittests/Utility/FileSpecTest.cpp

  Log Message:
  -----------
  [lldb] Add FileSpec::Equal unit tests

this is in preparation of a refactor of this method.


  Commit: b18e190b7ca90c09566382a039887f6eafe63d0d
      https://github.com/llvm/llvm-project/commit/b18e190b7ca90c09566382a039887f6eafe63d0d
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-11-28 (Thu, 28 Nov 2019)

  Changed paths:
    M lldb/source/Utility/FileSpec.cpp

  Log Message:
  -----------
  [lldb] refactor FileSpec::Equal

The logic of this function was quite hard to follow. Replace it with a
much simpler, equivalent, implementation.


Compare: https://github.com/llvm/llvm-project/compare/50e2ffa18da4...b18e190b7ca9