[all-commits] [llvm/llvm-project] d88f67: [llvm-readobj/llvm-readelf] - Reimplement dumping ...

[Georgii Rymar via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d88f67bdca7526c2adc3749bb2cfef6b32da971c
      https://github.com/llvm/llvm-project/commit/d88f67bdca7526c2adc3749bb2cfef6b32da971c
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2019-11-26 (Tue, 26 Nov 2019)

  Changed paths:
    M llvm/test/tools/llvm-readobj/elf-versioninfo.test
    M llvm/test/tools/yaml2obj/ELF/verdef-section.yaml
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readobj/llvm-readelf] - Reimplement dumping of the SHT_GNU_verdef section.

Currently we have following issues:
1) We have 2 different implementations with a different behaviors for GNU/LLVM styles.
2) Errors are either not handled at all or we call report_fatal_error with not helpfull messages.
3) There is no test coverage even for those errors that are reported.

This patch reimplements parsing of the SHT_GNU_verdef section entries
in a single place, adds a few error messages and test coverage.

Differential revision: https://reviews.llvm.org/D70495