[all-commits] [llvm/llvm-project] 1b2090: [X86] Return Op instead of SDValue() for lowering ...

topperc via All-commits all-commits at lists.llvm.org
Mon Nov 25 23:17:04 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b20908334847f4dc7b283f0493f4c59f1c62858
      https://github.com/llvm/llvm-project/commit/1b20908334847f4dc7b283f0493f4c59f1c62858
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-11-25 (Mon, 25 Nov 2019)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Return Op instead of SDValue() for lowering flags_read/write intrinsics

Returning SDValue() means we didn't handle it and the common
code should try to expand it. But its a target intrinsic so
expanding won't do anything and just leave the node alone. But
it will print confusing debug messages.

By returning Op we tell the common code that the node is legal
and shouldn't receive any further processing.




More information about the All-commits mailing list