[all-commits] [llvm/llvm-project] 90b8bc: IRGen: Call SetLLVMFunctionAttributes{, ForDefiniti...

[pcc via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 90b8bc003caacd165dedbb9cafc32de10d610ea7
      https://github.com/llvm/llvm-project/commit/90b8bc003caacd165dedbb9cafc32de10d610ea7
  Author: Peter Collingbourne <peter at pcc.me.uk>
  Date:   2019-11-25 (Mon, 25 Nov 2019)

  Changed paths:
    M clang/lib/CodeGen/CGExpr.cpp
    A clang/test/CodeGen/cfi-check-fail-attrs.c

  Log Message:
  -----------
  IRGen: Call SetLLVMFunctionAttributes{,ForDefinition} on __cfi_check_fail.

This has the main effect of causing target-cpu and target-features to be set
on __cfi_check_fail, causing the function to become ABI-compatible with other
functions in the case where these attributes affect ABI (e.g. reserve-x18).

Technically we only need to call SetLLVMFunctionAttributes to get the target-*
attributes set, but since we're creating a definition we probably ought to
call the ForDefinition function as well.

Fixes PR44094.

Differential Revision: https://reviews.llvm.org/D70692