[all-commits] [llvm/llvm-project] 7a6588: [lldb] Remove lldb's own ASTDumper

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7a6588abf8bac99d716188608adfbfb4928714db
      https://github.com/llvm/llvm-project/commit/7a6588abf8bac99d716188608adfbfb4928714db
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2019-11-25 (Mon, 25 Nov 2019)

  Changed paths:
    M lldb/include/lldb/Symbol/ClangUtil.h
    R lldb/source/Plugins/ExpressionParser/Clang/ASTDumper.cpp
    R lldb/source/Plugins/ExpressionParser/Clang/ASTDumper.h
    M lldb/source/Plugins/ExpressionParser/Clang/CMakeLists.txt
    M lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCDeclVendor.cpp
    M lldb/source/Symbol/ClangUtil.cpp

  Log Message:
  -----------
  [lldb] Remove lldb's own ASTDumper

Summary:
LLDB's ASTDumper is just a clone of Clang's ASTDumper but with some scary code and
some unrelated functionality (like dumping name/attributes of types). This removes LLDB's ASTDumper
and replaces its uses with the `ClangUtils::DumpDecl` method that just calls Clang's ASTDumper
and returns the result as a string.

The few uses where we just want a textual representation of a type (which will print their name/attributes but not
dump any AST) are now also in ClangUtil under a `ToString` name until we find a better home for them.

Reviewers: labath

Reviewed By: labath

Subscribers: mgorny, JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70663