[all-commits] [llvm/llvm-project] e84102: [clangd] Fix diagnostic location for macro expansions

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Mon Nov 25 01:47:13 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e841029aef74d99d1cb9443edd4a7b761d84ff45
      https://github.com/llvm/llvm-project/commit/e841029aef74d99d1cb9443edd4a7b761d84ff45
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2019-11-25 (Mon, 25 Nov 2019)

  Changed paths:
    M clang-tools-extra/clangd/Diagnostics.cpp
    M clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

  Log Message:
  -----------
  [clangd] Fix diagnostic location for macro expansions

Summary:
Diagnostic locations were broken when it was result of a macro
expansion. This patch fixes it by using expansion location instead of location
inside macro body.

Fixes https://github.com/clangd/clangd/issues/201.

Reviewers: hokein

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70494




More information about the All-commits mailing list