[all-commits] [llvm/llvm-project] ba4017: [Diagnostics] Warn for comparison with string lite...

[Dávid Bolvanský via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ba4017670e19f7b3b8f35410b29c5be1eb559a0a
      https://github.com/llvm/llvm-project/commit/ba4017670e19f7b3b8f35410b29c5be1eb559a0a
  Author: Dávid Bolvanský <david.bolvansky at gmail.com>
  Date:   2019-11-24 (Sun, 24 Nov 2019)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaExpr.cpp
    M clang/test/Sema/exprs.c
    A clang/test/Sema/warn-stringcompare.c

  Log Message:
  -----------
  [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

Summary:
As noted in PR, we have a poor test coverage for this warning. I think macro support was just overlooked. GCC warns in these cases.
Clang missed a real bug in the code I am working with, GCC caught it.

Reviewers: aaron.ballman

Reviewed By: aaron.ballman

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70624