[all-commits] [llvm/llvm-project] 70a3c9: [WebAssembly][SelectionDAG] Remove unused WebAssem...

hjyamauchi via All-commits all-commits at lists.llvm.org
Fri Nov 22 09:00:50 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 70a3c9f55f8494829d06caae0ab988da518d0e15
      https://github.com/llvm/llvm-project/commit/70a3c9f55f8494829d06caae0ab988da518d0e15
  Author: Hiroshi Yamauchi <yamauchi at google.com>
  Date:   2019-11-22 (Fri, 22 Nov 2019)

  Changed paths:
    M llvm/lib/Target/WebAssembly/WebAssemblyISelDAGToDAG.cpp

  Log Message:
  -----------
  [WebAssembly][SelectionDAG] Remove unused WebAssemblyDAGToDAGISel::ForCodeSize.

Summary:
This follows from the discussion at D70095.

D70095 moves hasOptSize calls into SelectionDAG::shouldOptForSize to allow
querying size optimization conditions together with profile guided size
optimization.

Since it appears that size optimizations for WebAssembly SelectionDAG haven't
been implemented yet and thus ForCodeSize is unused, and it would not make a lot
of sense to call shouldOptForSize here as the necessary profile data like
PSI/BFI aren't available at this point, it seems good and less confusing to
remove this for now and use shouldOptForSize when they are implemented in the
future.

Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, aheejin, sunfish, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70567




More information about the All-commits mailing list