[all-commits] [llvm/llvm-project] 1a58be: [JumpThreading] Use profile data even with the new...
kazutakahirata via All-commits
all-commits at lists.llvm.org
Fri Nov 22 08:22:36 PST 2019
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 1a58be2ac58ca078c91c9d1700220d88091b256f
https://github.com/llvm/llvm-project/commit/1a58be2ac58ca078c91c9d1700220d88091b256f
Author: Kazu Hirata <kazu at google.com>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M llvm/lib/Transforms/Scalar/JumpThreading.cpp
M llvm/test/Transforms/JumpThreading/update-edge-weight.ll
Log Message:
-----------
[JumpThreading] Use profile data even with the new pass manager
Summary:
Without this patch, the jump threading pass ignores profiling data
whenever we invoke the pass with the new pass manager.
Specifically, JumpThreadingPass::run calls runImpl with class variable
HasProfileData always set to false. In turn, runImpl sets
HasProfileData to false again:
HasProfileData = HasProfileData_;
In the end, we don't use profiling data at all with the new pass
manager.
This patch fixes the problem by passing F.hasProfileData() to runImpl.
The bug appears to have been introduced at:
https://reviews.llvm.org/D41461
which removed local variable HasProfileData in JumpThreadingPass::run
even though there was one more use left in the same function. As a
result, the remaining use ended referring to the class variable
instead.
Note that F.hasProfileData is an extremely lightweight function, so I
don't see the need to cache its result. Once this patch is approved,
I'm planning to stop caching the result of F.hasProfileData in
runOnFunction.
Reviewers: wmi, eli.friedman
Subscribers: hiraditya, jfb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70509
More information about the All-commits
mailing list