[all-commits] [llvm/llvm-project] 3b69f0: [NFC] Refactor and improve comments in CommandObje...

amccarth-google via All-commits all-commits at lists.llvm.org
Thu Nov 21 09:04:17 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3b69f0c5550a229dd6d39e361182cdd7cecc36a4
      https://github.com/llvm/llvm-project/commit/3b69f0c5550a229dd6d39e361182cdd7cecc36a4
  Author: Adrian McCarthy <amccarth at google.com>
  Date:   2019-11-21 (Thu, 21 Nov 2019)

  Changed paths:
    M lldb/source/Commands/CommandObjectTarget.cpp

  Log Message:
  -----------
  [NFC] Refactor and improve comments in CommandObjectTarget

Made small improvements while debugging through
CommandObjectTarget::AddModuleSymbols.

1.  Refactored error case for an early out, reducing the indentation of
the rest of this long function.
2.  Clarified some comments by correcting spelling and punctuation.
3.  Reduced duplicate code at the end of the function.

Tested with `ninja check-lldb`

Differential Review: https://reviews.llvm.org/D70458




More information about the All-commits mailing list