[all-commits] [llvm/llvm-project] d3fec7: LLD: Don't use the stderrOS stream in link before ...

[James Y Knight via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d3fec7fb456138c83b84e38ce785ea6bfa59c30b
      https://github.com/llvm/llvm-project/commit/d3fec7fb456138c83b84e38ce785ea6bfa59c30b
  Author: James Y Knight <jyknight at google.com>
  Date:   2019-11-21 (Thu, 21 Nov 2019)

  Changed paths:
    M lld/COFF/Driver.cpp
    M lld/COFF/DriverUtils.cpp
    M lld/Common/ErrorHandler.cpp
    M lld/ELF/Driver.cpp
    M lld/ELF/DriverUtils.cpp
    M lld/MinGW/Driver.cpp
    M lld/include/lld/Common/ErrorHandler.h
    M lld/lib/Driver/DarwinLdDriver.cpp
    M lld/wasm/Driver.cpp

  Log Message:
  -----------
  LLD: Don't use the stderrOS stream in link before it's reassigned.

Remove the lld::enableColors function, as it just obscures which
stream it's affecting, and replace with explicit calls to the stream's
enable_colors.

Also, assign the stderrOS and stdoutOS globals first in link function,
just to ensure nothing might use them.

(Either change individually fixes the issue of using the old
stream, but both together seems best.)

Follow-up to b11386f9be9b2dc7276a758d64f66833da10bdea.

Differential Revision: https://reviews.llvm.org/D70492