[all-commits] [llvm/llvm-project] 69242e: clang/Modules: Sink ASTReadResult in ReadControlBl...

[Duncan P. N. Exon Smith via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 69242e986823e3fdd11a8e51f47f36bec714363c
      https://github.com/llvm/llvm-project/commit/69242e986823e3fdd11a8e51f47f36bec714363c
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  clang/Modules: Sink ASTReadResult in ReadControlBlock, NFC

Simplify the code by avoiding some state that wasn't being used.  The
function-level `Result` was only assigned a value other than `Success`
in the handler for `OPTIONS_BLOCK_ID`, but in that case it also hits an
early return.  Remove it at the function-level to make it obvious that
the normal case always returns `Success`.