[all-commits] [llvm/llvm-project] 6e418d: [FileCheck] Use lit's internal shell for the test ...

Joel E. Denny via All-commits all-commits at lists.llvm.org
Tue Nov 19 09:13:34 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6e418decd936a3e22dec5cebc77ecb86dc7f37c3
      https://github.com/llvm/llvm-project/commit/6e418decd936a3e22dec5cebc77ecb86dc7f37c3
  Author: Joel E. Denny <jdenny.ornl at gmail.com>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M llvm/test/FileCheck/lit.local.cfg

  Log Message:
  -----------
  [FileCheck] Use lit's internal shell for the test suite

An advantage is that there are less portability concerns when writing
tests.  For example, `-u` is not supported by all implementations of
`env`, but lit's internal shell provides its own `env` that supports
`-u`.

A disadvantage is that some shell constructs, such as parentheses, are
not supported, but FileCheck's test suite currently doesn't require
such constructs.

For comparison, lit configures its test suite in the same manner.  See
`llvm/utils/lit/tests/lit.cfg`.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D70278




More information about the All-commits mailing list