[all-commits] [llvm/llvm-project] 39de82: [SLP] fix insertion point for min/max reduction

RotateRight via All-commits all-commits at lists.llvm.org
Tue Nov 19 07:53:38 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 39de82ecc9c2e461e1318ed9926286a1eed2be3f
      https://github.com/llvm/llvm-project/commit/39de82ecc9c2e461e1318ed9926286a1eed2be3f
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2019-11-19 (Tue, 19 Nov 2019)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
    M llvm/test/Transforms/SLPVectorizer/X86/reduction.ll

  Log Message:
  -----------
  [SLP] fix insertion point for min/max reduction

As discussed in D70148 (and caused a revert of the original commit):
if we insert at the select, then we can produce invalid IR because
the replacement for the compare may have uses before the select.




More information about the All-commits mailing list