[all-commits] [llvm/llvm-project] cc1b0b: [ThinLTO] Avoid extra index lookup during promotion

[Teresa Johnson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cc1b0bc24d2703087d80e4f4dc0560879733299a
      https://github.com/llvm/llvm-project/commit/cc1b0bc24d2703087d80e4f4dc0560879733299a
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2019-11-18 (Mon, 18 Nov 2019)

  Changed paths:
    M llvm/include/llvm/Transforms/Utils/FunctionImportUtils.h
    M llvm/lib/Transforms/Utils/FunctionImportUtils.cpp

  Log Message:
  -----------
  [ThinLTO] Avoid extra index lookup during promotion

Summary:
Pass down the already accessed ValueInfo to shouldPromoteLocalToGlobal,
to avoid an unnecessary extra index lookup.

Add some assertion checking to confirm we have a non-empty VI when
expected.

Also some misc cleanup, merging the two versions of
doImportAsDefinition, since one was only called by the other, and
unnecessarily passed in a member variable.

Reviewers: steven_wu, pcc, evgeny777

Reviewed By: evgeny777

Subscribers: mehdi_amini, inglorion, hiraditya, dexonsmith, arphaman, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70337