[all-commits] [llvm/llvm-project] 5a4a05: [libomptarget][nfc] Move some source into common f...

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Mon Nov 18 10:17:50 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a4a05d776d3adacad344b2b5e15cf594c906bce
      https://github.com/llvm/llvm-project/commit/5a4a05d776d3adacad344b2b5e15cf594c906bce
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2019-11-18 (Mon, 18 Nov 2019)

  Changed paths:
    A openmp/libomptarget/deviceRTLs/common/debug.h
    A openmp/libomptarget/deviceRTLs/common/src/cancel.cu
    A openmp/libomptarget/deviceRTLs/common/src/critical.cu
    A openmp/libomptarget/deviceRTLs/common/src/loop.cu
    A openmp/libomptarget/deviceRTLs/common/src/task.cu
    A openmp/libomptarget/deviceRTLs/common/state-queue.h
    A openmp/libomptarget/deviceRTLs/common/state-queuei.h
    M openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
    R openmp/libomptarget/deviceRTLs/nvptx/src/cancel.cu
    R openmp/libomptarget/deviceRTLs/nvptx/src/critical.cu
    R openmp/libomptarget/deviceRTLs/nvptx/src/debug.h
    R openmp/libomptarget/deviceRTLs/nvptx/src/loop.cu
    M openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h
    R openmp/libomptarget/deviceRTLs/nvptx/src/state-queue.h
    R openmp/libomptarget/deviceRTLs/nvptx/src/state-queuei.h
    M openmp/libomptarget/deviceRTLs/nvptx/src/support.cu
    R openmp/libomptarget/deviceRTLs/nvptx/src/task.cu

  Log Message:
  -----------
  [libomptarget][nfc] Move some source into common from nvptx

Summary:
[libomptarget][nfc] Move some source into common from nvptx

Moves some source that compiles cleanly under amdgcn into a common subdirectory
Includes some non-trivial files and some headers. Keeps the cuda file extension.

The build systems for different architectures seem unlikely to have much in
common. The idea is therefore to set include paths such that files under
common/src compile as if they were under arch/src as the mechanism for sharing.
In particular, files under common/src need to be able to include target_impl.h.

The corresponding -Icommon is left out in favour of explicit includes on the
basis that the it makes it clearer which files under common are used by a given
architecture.

Reviewers: jdoerfert, ABataev, grokos

Reviewed By: ABataev

Subscribers: jfb, mgorny, openmp-commits

Tags: #openmp

Differential Revision: https://reviews.llvm.org/D70328




More information about the All-commits mailing list