[all-commits] [llvm/llvm-project] 4f80fc: [clangd] Implement rename by using SelectionTree a...

[Haojian Wu via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4f80fc2491cc35730a9a84b86975278b7daa8522
      https://github.com/llvm/llvm-project/commit/4f80fc2491cc35730a9a84b86975278b7daa8522
  Author: Haojian Wu <hokein.wu at gmail.com>
  Date:   2019-11-18 (Mon, 18 Nov 2019)

  Changed paths:
    M clang-tools-extra/clangd/refactor/Rename.cpp
    M clang-tools-extra/clangd/unittests/RenameTests.cpp

  Log Message:
  -----------
  [clangd] Implement rename by using SelectionTree and findExplicitReferences.

Summary:
With the new implemenation, we will have better coverage of various AST
nodes, and fix some known/potential bugs.

Also added the existing clang-renamae tests. Known changed behavior:
 - "~Fo^o()" will not trigger the rename, will fix afterwards
 - references in macro bodies are not renamed now

This fixes:
- https://github.com/clangd/clangd/issues/167
- https://github.com/clangd/clangd/issues/169
- https://github.com/clangd/clangd/issues/171

Reviewers: ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69934