[all-commits] [llvm/llvm-project] dca2b3: Re-commit "DWARF location lists: Add section index...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dca2b36ba097085663ae8473f01f0353c33f7ff0
      https://github.com/llvm/llvm-project/commit/dca2b36ba097085663ae8473f01f0353c33f7ff0
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-11-18 (Mon, 18 Nov 2019)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFAddressRange.h
    M llvm/lib/DebugInfo/DWARF/DWARFAddressRange.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
    M llvm/test/CodeGen/X86/debug-loclists.ll
    M llvm/test/DebugInfo/ARM/PR26163.ll
    M llvm/test/DebugInfo/Mips/dsr-fixed-objects.ll
    M llvm/test/DebugInfo/X86/DW_AT_location-reference.ll
    M llvm/test/DebugInfo/X86/constant-loclist.ll
    M llvm/test/DebugInfo/X86/dbg-value-frame-index.ll
    M llvm/test/DebugInfo/X86/dbg-value-regmask-clobber.ll
    M llvm/test/DebugInfo/X86/debug-loc-frame.ll
    M llvm/test/DebugInfo/X86/debug-loc-offset.mir

  Log Message:
  -----------
  Re-commit "DWARF location lists: Add section index dumping"

This reapplies c0f6ad7d1f3ccb9d0b9ce9ef8dfa06409ccf1b3e with an
additional fix in test/DebugInfo/X86/constant-loclist.ll, which had a
slightly different output on windows targets. The test now accounts for
this difference.

The original commit message follows.

Summary:
As discussed in D70081, this adds the ability to dump section
names/indices to the location list dumper. It does this by moving the
range specific logic from DWARFDie.cpp:dumpRanges into the
DWARFAddressRange class.

The trickiest part of this patch is the backflip in the meanings of the
two dump flags for the location list sections.

The dumping of "raw" location list data is now controlled by
"DisplayRawContents" flag. This frees up the "Verbose" flag to be used
to control whether we print the section index. Additionally, the
DisplayRawContents flag is set for section-based dumps whenever the
--verbose option is passed, but this is not done for the "inline" dumps.

Also note that the index dumping currently does not work for the DWARF
v5 location lists, as the parser does not fill out the appropriate
fields. This will be done in a separate patch.

Reviewers: dblaikie, probinson, JDevlieghere, SouraVX

Subscribers: sdardis, hiraditya, jrtc27, atanasyan, arphaman, aprantl, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70227