[all-commits] [llvm/llvm-project] a578ad: dotest: Add a way for the run_to_* helpers to regi...

[fredriss via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a578adc1bc8e17b147ed5ef4794cd6f3f82b584b
      https://github.com/llvm/llvm-project/commit/a578adc1bc8e17b147ed5ef4794cd6f3f82b584b
  Author: Fred Riss <friss at apple.com>
  Date:   2019-11-15 (Fri, 15 Nov 2019)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py
    M lldb/packages/Python/lldbsuite/test/lldbutil.py

  Log Message:
  -----------
  dotest: Add a way for the run_to_* helpers to register dylibs

Summary:
To run the testsuite remotely the executable needs to be uploaded to
the target system. The Target takes care of this by default.

When the test uses additional shared libraries, those won't be handled
by default and need to be registered with the target using
test.registerSharedLibrariesWithTarget(target, dylib).

Calling this API requires a target, so it doesn't mesh well with the
run_to_* helpers that we've been advertising as the right way to write
tests.

This patch adds an extra_images argument to all the helpers and does
the registration automatically when running a remote
testsuite. TestWeakSymbols.py was converted to use this new scheme.

Reviewers: jingham

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70134