[all-commits] [llvm/llvm-project] 631be5: Remove Support/Options.h, it is unused

[Reid Kleckner via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 631be5c0d41161057d02fe08a7aeb4fbde1a91d6
      https://github.com/llvm/llvm-project/commit/631be5c0d41161057d02fe08a7aeb4fbde1a91d6
  Author: Reid Kleckner <rnk at google.com>
  Date:   2019-11-15 (Fri, 15 Nov 2019)

  Changed paths:
    M clang/tools/clang-scan-deps/ClangScanDeps.cpp
    M llvm/include/llvm/IR/LLVMContext.h
    R llvm/include/llvm/Support/Options.h
    M llvm/lib/Support/CMakeLists.txt
    M llvm/lib/Support/DebugCounter.cpp
    R llvm/lib/Support/Options.cpp
    M llvm/lib/Support/Signals.cpp
    M llvm/lib/Transforms/Scalar/Scalarizer.cpp

  Log Message:
  -----------
  Remove Support/Options.h, it is unused

It was added in 2014 in 732e0aa9fb84f1 with one use in Scalarizer.cpp.
That one use was then removed when porting to the new pass manager in
2018 in b6f76002d9158628e78.

While the RFC and the desire to get off of static initializers for
cl::opt all still stand, this code is now dead, and I think we should
delete this code until someone is ready to do the migration.

There were many clients of CommandLine.h that were it transitively
through LLVMContext.h, so I cleaned that up in 4c1a1d3cf97e1ede466.

Reviewers: beanz

Differential Revision: https://reviews.llvm.org/D70280