[all-commits] [llvm/llvm-project] cb1761: clang: enable unwind tables on FreeBSD !amd64

[Ed Maste via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cb1761465a0d4c904f4fca489afe97478382b553
      https://github.com/llvm/llvm-project/commit/cb1761465a0d4c904f4fca489afe97478382b553
  Author: Ed Maste <emaste at freebsd.org>
  Date:   2019-11-15 (Fri, 15 Nov 2019)

  Changed paths:
    M clang/lib/Driver/ToolChains/FreeBSD.cpp
    M clang/lib/Driver/ToolChains/FreeBSD.h
    M clang/test/Driver/freebsd.c

  Log Message:
  -----------
  clang: enable unwind tables on FreeBSD !amd64

There doesn't seem to be much sense in defaulting "on" unwind tables on
amd64 and not on other arches. It causes surprising differences between
platforms, such as the PR below[1].

Prior to this change, FreeBSD inherited the default implementation of the
method from the Gnu.h Generic_Elf => Generic_GCC parent class, which
returned true only for amd64 targets.  Override that and opt on always,
similar to, e.g., NetBSD's driver.

[1] https://bugs.freebsd.org/241562

Patch by cem (Conrad Meyer).

Reviewed By: dim

Differential Revision: https://reviews.llvm.org/D70110