[all-commits] [llvm/llvm-project] a2292c: [ThinLTO] Add correctness check for RO/WO variable...

eleviant via All-commits all-commits at lists.llvm.org
Thu Nov 14 01:28:49 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a2292cc537b561416c21e8d4017715d652c144cc
      https://github.com/llvm/llvm-project/commit/a2292cc537b561416c21e8d4017715d652c144cc
  Author: evgeny <eleviant at accesssoftek.com>
  Date:   2019-11-14 (Thu, 14 Nov 2019)

  Changed paths:
    M llvm/include/llvm/LTO/LTO.h
    M llvm/include/llvm/Transforms/IPO/FunctionImport.h
    M llvm/include/llvm/Transforms/IPO/WholeProgramDevirt.h
    M llvm/lib/LTO/LTO.cpp
    M llvm/lib/LTO/ThinLTOCodeGenerator.cpp
    M llvm/lib/Transforms/IPO/FunctionImport.cpp
    M llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
    M llvm/lib/Transforms/Utils/FunctionImportUtils.cpp

  Log Message:
  -----------
  [ThinLTO] Add correctness check for RO/WO variable import

This patch adds an assertion check for exported read/write-only
variables to be also in import list for module. If they aren't
we may face linker errors, because read/write-only variables are
internalized in their source modules. The patch also changes
export lists to store ValueInfo instead of GUID for performance
considerations.

Differential revision: https://reviews.llvm.org/D70128




More information about the All-commits mailing list