[all-commits] [llvm/llvm-project] bfe663: Revert a hunk from 9634064cfa1b9bf7b7

Reid Kleckner via All-commits all-commits at lists.llvm.org
Wed Nov 13 15:44:12 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bfe663ce22db6697459510ae5c139da2197df56c
      https://github.com/llvm/llvm-project/commit/bfe663ce22db6697459510ae5c139da2197df56c
  Author: Reid Kleckner <rnk at google.com>
  Date:   2019-11-13 (Wed, 13 Nov 2019)

  Changed paths:
    M lldb/include/lldb/Utility/Connection.h

  Log Message:
  -----------
  Revert a hunk from 9634064cfa1b9bf7b7

This causes errors when building LLDB because the Windows implementation
doesn't implement this method:

C:\src\llvm-project\lldb\source\Plugins\ScriptInterpreter\Python\ScriptInterpreterPython.cpp(915,19): error: allocating an object of abstract class type 'lldb_private::ConnectionGenericFile'
              new ConnectionGenericFile(read_file, true));
                  ^
C:\src\llvm-project\lldb\include\lldb/Utility/Connection.h(174,28): note: unimplemented pure virtual method 'GetReadObject' in 'ConnectionGenericFile'
  virtual lldb::IOObjectSP GetReadObject() = 0;
                           ^




More information about the All-commits mailing list