[all-commits] [llvm/llvm-project] ebe2f5: DWARFDebugLoclists: add location list "interpretat...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ebe2f56030458e7a4c2375c6d92a48f0ed01eb5b
      https://github.com/llvm/llvm-project/commit/ebe2f56030458e7a4c2375c6d92a48f0ed01eb5b
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-11-12 (Tue, 12 Nov 2019)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h
    A llvm/include/llvm/DebugInfo/DWARF/DWARFLocationExpression.h
    M llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
    M llvm/test/CodeGen/X86/debug-loclists.ll
    M llvm/test/DebugInfo/X86/fission-ranges.ll
    M llvm/test/DebugInfo/X86/loclists-dwp.ll
    M llvm/test/tools/llvm-dwarfdump/X86/debug_loc_dwo.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_loclists.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_loclists_startx_length.s

  Log Message:
  -----------
  DWARFDebugLoclists: add location list "interpretation" logic

Summary:
This patch extracts the logic for computing the "absolute" locations,
which was partially present in the debug_loclists dumper, completes it,
and moves it into a separate function. This makes it possible to later
reuse the same logic for uses other than dumping.

The dumper is changed to reuse the location list interpreter, and its
format is changed somewhat. In "verbose" mode it prints the "raw" value
of a location list, the interpreted location (if available) and the
expression itself. In non-verbose mode it prints only one of the
location forms: it prefers the interpreted form, but falls back to the
"raw" format if interpretation is not possible (for instance, because we
were not given a base address, or the resolution of indirect addresses
failed).

This patch also undos some of the changes made in D69672, namely the
part about making all functions static. The main reason for this is that
I learned that the original approach (dumping only fully resolved
locations) meant that it was impossible to rewrite one of the existing
tests. To make that possible (and make the "inline location" dump work
in more cases), I now reuse the same dumping mechanism as is used for
section-based dumping. As this required having more objects know about
the various location lists classes, it seemed like a good idea to create
an interface abstracting the difference between them.

Therefore, I now create a DWARFLocationTable class, which will serve as
a base class for the location list classes. DWARFDebugLoclists is made
to inherit from that. DWARFDebugLoc will follow.

Another positive effect of this change is that section-based dumping
code will not need to use templates (as originally) envisioned, and that
the argument lists of the dumping functions become shorter.

Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70081