[all-commits] [llvm/llvm-project] 31ea71: Add rpath to liblldb so vendors can ship their own...

António Afonso via All-commits all-commits at lists.llvm.org
Mon Nov 11 19:27:45 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 31ea714e9a94d3912988c06139cb987e14478e84
      https://github.com/llvm/llvm-project/commit/31ea714e9a94d3912988c06139cb987e14478e84
  Author: António Afonso <aadsm at fb.com>
  Date:   2019-11-11 (Mon, 11 Nov 2019)

  Changed paths:
    M lldb/cmake/modules/LLDBFramework.cmake

  Log Message:
  -----------
  Add rpath to liblldb so vendors can ship their own python framework (or others)

Summary:
I want to be able to specify which python framework to use for lldb in macos. With python2.7 we could just rely on the MacOS one but python3.7 is not shipped with the OS.
An alternative is to use the one shipped with Xcode but that could be path dependent or maybe the user doesn't have Xcode installed at all.
A definite solution is to just ship a python framework with lldb. To make this possible I added "@loader_path/../../../" to the rpath so it points to the same directory as the LLDB.framework, this way we can just drop any frameworks there.

Reviewers: hhb, sgraenitz, xiaobai, smeenai, beanz, labath

Reviewed By: labath

Subscribers: beanz, labath, mgorny, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D69931




More information about the All-commits mailing list