[all-commits] [llvm/llvm-project] bfd58f: clang/Modules: Use range-based for in ASTReader::R...

[Duncan P. N. Exon Smith via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bfd58fc60ff4b0c081b5b489119c3798d3e2b53c
      https://github.com/llvm/llvm-project/commit/bfd58fc60ff4b0c081b5b489119c3798d3e2b53c
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2019-11-11 (Mon, 11 Nov 2019)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  clang/Modules: Use range-based for in ASTReader::ReadAST, NFC


  Commit: 01782c3e4df1830d7991e9edfee9119ed41e4c27
      https://github.com/llvm/llvm-project/commit/01782c3e4df1830d7991e9edfee9119ed41e4c27
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2019-11-11 (Mon, 11 Nov 2019)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  clang/Modules: Split loop in ReadAST between failable and not

Split a loop in ReadAST that visits the just-loaded module chain,
between an initial loop that reads further from the ASTs (and can fail)
and a second loop that does some preloading (and cannot fail).  This
makes it less likely for a reading failure to affect the AST.

This is not fixing a known bug and the behaviour change may not be
observable, it's just part of an audit to look at all of the error
handling in the ASTReader.

https://reviews.llvm.org/D70056


Compare: https://github.com/llvm/llvm-project/compare/e5e2e0a66b03...01782c3e4df1