[all-commits] [llvm/llvm-project] d24bce: Add a testcase for .dSYM path remapping dictionaries.

[adrian-prantl via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d24bce57c3ca2414ff5e53d8f7f3f007d6a946fe
      https://github.com/llvm/llvm-project/commit/d24bce57c3ca2414ff5e53d8f7f3f007d6a946fe
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2019-11-11 (Mon, 11 Nov 2019)

  Changed paths:
    A lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/main.c
    A lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Makefile
    A lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/TestDSYMSourcePathRemapping.py

  Log Message:
  -----------
  Add a testcase for .dSYM path remapping dictionaries.

rdar://problem/56924558


  Commit: da83e96273527a137f2ebd77cedb920180eab621
      https://github.com/llvm/llvm-project/commit/da83e96273527a137f2ebd77cedb920180eab621
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2019-11-11 (Mon, 11 Nov 2019)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/main.c
    A lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Inputs/relative.c
    M lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/Makefile
    M lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/TestDSYMSourcePathRemapping.py
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

  Log Message:
  -----------
  Fix a regression in macOS-style path remapping.

When we switched to the LLVM .debug_line parser, the .dSYM-style path
remapping logic stopped working for relative paths because of how
RemapSourceFile silently fails for relative paths. This patch both
makes the code more readable and fixes this particular bug.

One interesting thing I learned is that Module::RemapSourceFile() is a
macOS-only code path that operates on on the lldb::Module level and is
completely separate from target.source-map, which operates on a
per-Target level.

Differential Revision: https://reviews.llvm.org/D70037

rdar://problem/56924558


  Commit: 646d927175ebd0bb1d7af7d51b41bc1d7b1fe651
      https://github.com/llvm/llvm-project/commit/646d927175ebd0bb1d7af7d51b41bc1d7b1fe651
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2019-11-11 (Mon, 11 Nov 2019)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/macosx/DBGSourcePathRemapping/TestDSYMSourcePathRemapping.py

  Log Message:
  -----------
  Replace tabs with spaces. (NFC)


Compare: https://github.com/llvm/llvm-project/compare/e0f1d9d8729d...646d927175eb