[all-commits] [llvm/llvm-project] 41104a: [clangd] Fix a regression of not showing documenta...

[Haojian Wu via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 41104a9406dd284d984f7bee30c7756fcfe2b59e
      https://github.com/llvm/llvm-project/commit/41104a9406dd284d984f7bee30c7756fcfe2b59e
  Author: Haojian Wu <hokein.wu at gmail.com>
  Date:   2019-11-11 (Mon, 11 Nov 2019)

  Changed paths:
    M clang-tools-extra/clangd/index/Merge.cpp
    M clang-tools-extra/clangd/unittests/IndexTests.cpp

  Log Message:
  -----------
  [clangd] Fix a regression of not showing documentation from forward declarations.

Summary:
There is a regression from https://reviews.llvm.org/D68467. Unlike class
forward declarations, function ducomentation is written in the declaration in
headers, the function definition doesn't contain any documentation, cases like:

```
foo.h
// this is foo.
void foo();
foo.cc

void foo() {}
```
we should still show documentation from the foo declaration.

Reviewers: ilya-biryukov

Reviewed By: ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69961