[all-commits] [llvm/llvm-project] 39c308: DebugInfo: Use separate macinfo contributions for ...

[David Blaikie via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 39c308f6b8f06710b2b98d0b126c9175e4bafc20
      https://github.com/llvm/llvm-project/commit/39c308f6b8f06710b2b98d0b126c9175e4bafc20
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2019-11-08 (Fri, 08 Nov 2019)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
    M llvm/test/DebugInfo/NVPTX/cu-range-hole.ll
    M llvm/test/DebugInfo/NVPTX/debug-addr-class.ll
    M llvm/test/DebugInfo/NVPTX/debug-file-loc.ll
    M llvm/test/DebugInfo/NVPTX/debug-info.ll
    M llvm/test/DebugInfo/NVPTX/debug-loc-offset.ll
    M llvm/test/DebugInfo/X86/debug-macro.ll
    M llvm/test/DebugInfo/X86/empty_macinfo.ll
    M llvm/test/MC/WebAssembly/debug-info.ll

  Log Message:
  -----------
  DebugInfo: Use separate macinfo contributions for each CU

The macinfo support was broken for LTO situations, by terminating
macinfo lists only once - multiple macinfo contributions were correctly
labeled, but they all continued/flowed into later contributions until
only one terminator appeared at the end of the section.

Correctly terminate each contribution & fix the parsing to handle this
situation too. The parsing fix is also necessary for dumping linked
binaries - the previous code would stop at the end of the first
contribution - missing all later contributions in a linked binary.

It'd be nice to improve the dumping to print the offsets of each
contribution so it'd be easier to know which CU AT_macro_info refers to
which macinfo contribution.